removed sudo from npm install and provides a check instead #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #!/bin/sh | ||
|
|
||
| # check for libcairo2 | ||
| if [ -f /usr/include/cairo/cairo.h ]; then |
There was a problem hiding this comment.
Would this approach works for other platforms e.g) redhat?
There was a problem hiding this comment.
My thought was /usr/include is pretty standard for installing headers. I can add an or check for /usr/local/include/cairo/cairo.h as well that might be more robust. We can add locations as they come up if needed. If there are not other objections I think we should merge and do an initial release of this patch since I know of several cases blocking on the the sudo problem.
rctoris
added a commit
that referenced
this pull request
Apr 10, 2015
removed sudo from npm install and provides a check instead
|
👍 |
k-aguete
pushed a commit
to k-aguete/roslibjs
that referenced
this pull request
Oct 21, 2022
Error in console instead of throwing exception RobotWebTools#178 Since this is intended to be a warning, we can print an error to the console instead of throwing an exception, which causes script execution to halt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #177